Skip to content

Commit

Permalink
Minor fixes on getfoldstatus and imports
Browse files Browse the repository at this point in the history
  • Loading branch information
Sebastian Neira committed Apr 9, 2024
1 parent b345676 commit 3f78c09
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
8 changes: 4 additions & 4 deletions temporalcli/commands.workflow_trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ var workflowTraceFoldFlags = map[string]enums.WorkflowExecutionStatus{

func (c *TemporalWorkflowTraceCommand) getFoldStatuses() ([]enums.WorkflowExecutionStatus, error) {
// defaults
if len(foldFlags) == 0 {
if len(c.Fold) == 0 {
return []enums.WorkflowExecutionStatus{
enums.WORKFLOW_EXECUTION_STATUS_COMPLETED,
enums.WORKFLOW_EXECUTION_STATUS_CANCELED,
Expand All @@ -37,8 +37,8 @@ func (c *TemporalWorkflowTraceCommand) getFoldStatuses() ([]enums.WorkflowExecut

// parse flags
var values []enums.WorkflowExecutionStatus
for _, flag := range foldFlags {
status, ok := foldFlag[flag]
for _, flag := range c.Fold {
status, ok := workflowTraceFoldFlags[flag]
if !ok {
return nil, fmt.Errorf("fold status %q not recognized", flag)
}
Expand All @@ -62,7 +62,7 @@ func (c *TemporalWorkflowTraceCommand) run(cctx *CommandContext, _ []string) err
Concurrency: c.Concurrency,
NoFold: c.NoFold,
}
opts.FoldStatuses, err = getFoldStatuses(c.Fold)
opts.FoldStatuses, err = c.getFoldStatuses()
if err != nil {
return err
}
Expand Down
4 changes: 1 addition & 3 deletions temporalcli/commands.workflow_trace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ import (
"time"

"go.temporal.io/api/enums/v1"

"go.temporal.io/sdk/workflow"

"go.temporal.io/sdk/client"
"go.temporal.io/sdk/workflow"
)

func (s *SharedServerSuite) TestWorkflow_Trace_Summary() {
Expand Down

0 comments on commit 3f78c09

Please sign in to comment.