-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Login Info from whole lines in Client #103
Conversation
The Client captures stdout into a buffer, splits it into lines with strings.Fields() and parses the Login Info in those lines. But Login Info values like the Cookie can contain white space characters which results in parsing incomplete lines. So, extract whole lines from the buffer with a bufio.Scanner and use them to parse the Login Info. Signed-off-by: hwipl <33433250+hwipl@users.noreply.github.com>
Test Result🙌 258 Tests pass Test Details🟢 TestAddrMonStartStop (0.00s) CoverageTotal coverage: 🟩🟩🟩🟥 78.7% Coverage Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Client captures stdout into a buffer, splits it into lines with strings.Fields() and parses the Login Info in those lines. But Login Info values like the Cookie can contain white space characters which results in parsing incomplete lines. So, extract whole lines from the buffer with a bufio.Scanner and use them to parse the Login Info.