Add ECC key creation support #95
Conversation
- Prefix variable names with role_name - Make registered variables naming more clear with the result suffix
|
LGTM! However this would be a breaking change, right? Existing keys will be recreated.. As per docs from community.crypto.openssl_privatekey:
|
There was a problem hiding this comment.
from reviewing the code of community.crypto I think that the parameters for size and curve are mutually exclusive. Not in a way that generates an error, but when we use ECC keys, we only need to specify the curve, and when wie use RSA we need to specify the keysize. Specifying both is not expected and not needed.
rndmh3ro
added
major
breaking
Set 4096bit default keysize in case RSA is used Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com> Co-authored-by: schurzi <Martin.Schurz@t-systems.com>
|
Is this something that will be merged soon? or if we need we should just cherry-pick it? |
|
Hi, @darkspadez i will resolve conflicts and merge this PR today or in the next days. Sorry for the wait |
Defaults for key size and curve are oriented on recomendations from https://docs.ansible.com/ansible/latest/collections/community/crypto/openssl_privatekey_module.html#parameter-curve
and https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8.
If a type is used which does not use curves the openssl modul seems to ignore the value thus does not affect the creation of other key types. I tested it with RSA.