-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECC key creation support #95
Conversation
- Prefix variable names with role_name - Make registered variables naming more clear with the result suffix
LGTM! However this would be a breaking change, right? Existing keys will be recreated.. As per docs from community.crypto.openssl_privatekey:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from reviewing the code of community.crypto
I think that the parameters for size
and curve
are mutually exclusive. Not in a way that generates an error, but when we use ECC keys, we only need to specify the curve, and when wie use RSA we need to specify the keysize. Specifying both is not expected and not needed.
Set 4096bit default keysize in case RSA is used Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com> Co-authored-by: schurzi <Martin.Schurz@t-systems.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick: please correct spaces in readme
Is this something that will be merged soon? or if we need we should just cherry-pick it? |
Hi, @darkspadez i will resolve conflicts and merge this PR today or in the next days. Sorry for the wait |
Defaults for key size and curve are oriented on recomendations from https://docs.ansible.com/ansible/latest/collections/community/crypto/openssl_privatekey_module.html#parameter-curve
and https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8.
If a type is used which does not use curves the openssl modul seems to ignore the value thus does not affect the creation of other key types. I tested it with RSA.