[TEP-0056]: Initial set of API refactors pertinent to Pipelines in Pipelines #7055

bhujangr · 2023-08-18T15:20:18Z

Changes

This is the first of many pull requests to begin implementing TEP-0056

Added PipelineRef and PipelineSpec to PipelineTask
Updated and added pipeline validation tests to reflect the above additions
Updated and added pipeline type tests to reflect the above additions
Added a initial set of docs and examples using the existing proposal

The changes in this PR does not change existing behavior and merely introduces fields to existing types

Note: Pipelines in Pipelines is not yet implemented

Co-authored-by: pritidesai pdesai@us.ibm.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Added PipelineRef and PipelineSpec fields to PipelineTask, in lieu of TEP-0056

tekton-robot · 2023-08-18T15:20:27Z

Hi @bhujangr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop

Thank you so much @bhujangr for picking up this work, and welcome to Tekton! 🙏🏾
cc @pritidesai @abayer

/assign
/meow

tekton-robot · 2023-08-18T15:25:06Z

@jerop:

In response to this:

Thank you so much @bhujangr for picking up this work, and welcome to Tekton! 🙏🏾
cc @pritidesai @abayer

/assign
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pritidesai · 2023-08-18T15:26:48Z

/ok-to-test
/kind feature

tekton-robot · 2023-08-18T15:27:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

pritidesai · 2023-08-18T15:27:34Z

thanks @bhujangr, please update the release notes section in the PR description. Thanks!

pkg/apis/pipeline/v1/pipeline_validation.go

tekton-robot · 2023-08-18T15:32:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

bhujangr · 2023-08-18T15:40:02Z

@pritidesai added release notes, not quite sure if it is in the right format and in line with what is expected

tekton-robot · 2023-08-18T15:52:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-18T15:53:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-18T15:55:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-18T16:37:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-18T16:37:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-18T16:37:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

pkg/apis/pipeline/v1/pipeline_types.go

docs/pipelines.md

pkg/apis/pipeline/v1/pipeline_types_test.go

docs/pipelines.md

pkg/apis/pipeline/v1/pipeline_validation_test.go

pritidesai · 2023-08-23T17:57:43Z

pkg/apis/pipeline/v1/pipeline_validation.go

+		cfg := config.FromContextOrDefaults(ctx)
+		// if alpha API's are enabled, we
+		if cfg.FeatureFlags.EnableAPIFields == config.AlphaAPIFields {
+			errs = errs.Also(apis.ErrMissingOneOf("taskRef", "taskSpec", "pipelineRef", "pipelineSpec"))


Nit: declaring a constants for "taskRef", "taskSpec", "pipelineRef", and "pipelineSpec" and reusing them everywhere instead of hardcoding the string.

tekton-robot · 2023-08-25T16:24:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-25T16:26:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-25T17:51:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

tekton-robot · 2023-08-25T17:53:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0

pritidesai · 2023-08-25T18:26:12Z

Looks like a flake:

task-beta/cmd/controller
        2023/08/25 17:59:08 Building github.com/tektoncd/pipeline/test/wait-task-beta/cmd/controller for linux/amd64
        2023/08/25 17:59:08 Building github.com/tektoncd/pipeline/test/wait-task-beta/cmd/controller for linux/ppc64le
        2023/08/25 17:59:17 Unexpected error running "go build": signal: killed
        2023/08/25 17:59:17 Unexpected error running "go build": signal: killed
        error: no objects passed to apply
        Error: error processing import paths in "./config/controller.yaml": error resolving image references: GET https://distroless.dev/v2/static/manifests/sha256:5ca443a329d0c2fd7bd28a58d67fd19c7fee14e644e1492ffe9dd4741b6ff9de: unexpected status code 500 Internal Server Error: 
        <html><head>
        <meta http-equiv="content-type" content="text/html;charset=utf-8">
        <title>500 Server Error</title>
        </head>
        <body text=#000000 bgcolor=#ffffff>
        <h1>Error: Server Error</h1>
        <h2>The server encountered an error and could not complete your request.<p>Please try again in 30 seconds.</h2>
        <h2></h2>
        </body></html>
        
        2023/08/25 17:59:17 error during command execution:error processing import paths in "./config/controller.yaml": error resolving image references: GET https://distroless.dev/v2/static/manifests/sha256:5ca443a329d0c2fd7bd28a58d67fd19c7fee14e644e1492ffe9dd4741b6ff9de: unexpected status code 500 Internal Server Error: 
        <html><head>
        <meta http-equiv="content-type" content="text/html;charset=utf-8">
        <title>500 Server Error</title>
        </head>
        <body text=#000000 bgcolor=#ffffff>
        <h1>Error: Server Error</h1>
        <h2>The server encountered an error and could not complete your request.<p>Please try again in 30 seconds.</h2>
        <h2></h2>
        </body></html>

tekton-robot · 2023-08-25T20:58:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	98.7%	98.8%	0.1

tekton-robot · 2023-08-25T20:59:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	98.7%	98.8%	0.1

JeromeJu · 2023-09-05T16:44:00Z

/assign

docs/pipelines-in-pipelines.md

pkg/apis/pipeline/v1/pipeline_types_test.go

pkg/apis/pipeline/v1/pipeline_validation.go

…pelines This is the first of many commits to begin implementing TEP-0056 - Added PipelineRef and PipelineSpec to PipelineTask - Updated and added pipeline validation tests to reflect the above additions - Updated and added pipeline type tests to reflect the above additions - Added a initial set of docs and examples using the existing proposal - The changes in this PR does not change existing behavior and merely introduces fields to existing types Note: Pipelines in Pipelines is not yet implemented Signed-off-by: Priti Desai <pdesai@us.ibm.com>

tekton-robot · 2023-09-05T18:48:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	98.7%	98.8%	0.1

tekton-robot · 2023-09-05T18:49:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.1%	99.1%	0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	98.7%	98.8%	0.1

jerop

/lgtm

tekton-robot · 2023-09-05T21:08:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jerop,lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 18, 2023

tekton-robot requested review from bobcatfish and jerop August 18, 2023 15:20

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2023

jerop reviewed Aug 18, 2023

View reviewed changes

tekton-robot assigned jerop Aug 18, 2023

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2023

jerop reviewed Aug 18, 2023

View reviewed changes

pkg/apis/pipeline/v1/pipeline_validation.go Outdated Show resolved Hide resolved

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Aug 18, 2023

bhujangr force-pushed the pipelines-in-pipelines-fields-tests-docs branch from 86404ce to 41d994b Compare August 18, 2023 15:47

bhujangr force-pushed the pipelines-in-pipelines-fields-tests-docs branch from e1ef312 to 9f518dc Compare August 18, 2023 16:30

pritidesai reviewed Aug 18, 2023

View reviewed changes

pkg/apis/pipeline/v1/pipeline_types.go Show resolved Hide resolved

tekton-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 20, 2023

pritidesai reviewed Aug 23, 2023

View reviewed changes

docs/pipelines.md Outdated Show resolved Hide resolved

pritidesai reviewed Aug 23, 2023

View reviewed changes

pkg/apis/pipeline/v1/pipeline_types_test.go Outdated Show resolved Hide resolved

khrm reviewed Aug 23, 2023

View reviewed changes

docs/pipelines.md Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/pipeline_validation_test.go Show resolved Hide resolved

pritidesai reviewed Aug 23, 2023

View reviewed changes

khrm mentioned this pull request Aug 24, 2023

Support Pipelines in Pipelines [TEP-0056] tektoncd/results#578

Open

pritidesai force-pushed the pipelines-in-pipelines-fields-tests-docs branch from 05b1078 to f722895 Compare August 25, 2023 16:18

pritidesai force-pushed the pipelines-in-pipelines-fields-tests-docs branch from f722895 to 8173077 Compare August 25, 2023 17:45

pritidesai force-pushed the pipelines-in-pipelines-fields-tests-docs branch from 8173077 to e0d7d0c Compare August 25, 2023 20:51

pritidesai added this to the Pipelines v0.52 milestone Sep 2, 2023

tekton-robot assigned JeromeJu Sep 5, 2023

lbernick approved these changes Sep 5, 2023

View reviewed changes

docs/pipelines-in-pipelines.md Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/pipeline_types_test.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/pipeline_validation.go Outdated Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023

pritidesai force-pushed the pipelines-in-pipelines-fields-tests-docs branch from e0d7d0c to bf2597e Compare September 5, 2023 18:41

jerop approved these changes Sep 5, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023

tekton-robot merged commit 6150191 into tektoncd:main Sep 5, 2023
12 checks passed

QuanZhang-William mentioned this pull request Sep 29, 2023

[TEP-0050] Add OnError field #7162

Merged

7 tasks

jerop mentioned this pull request Sep 29, 2023

TEP-0056: Pipelines in Pipelines #7166

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP-0056]: Initial set of API refactors pertinent to Pipelines in Pipelines #7055

[TEP-0056]: Initial set of API refactors pertinent to Pipelines in Pipelines #7055

bhujangr commented Aug 18, 2023 •

edited by pritidesai

Loading

tekton-robot commented Aug 18, 2023

jerop left a comment

tekton-robot commented Aug 18, 2023

pritidesai commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

pritidesai commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

bhujangr commented Aug 18, 2023 •

edited

Loading

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

pritidesai Aug 23, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

pritidesai commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

JeromeJu commented Sep 5, 2023

tekton-robot commented Sep 5, 2023

tekton-robot commented Sep 5, 2023

jerop left a comment

tekton-robot commented Sep 5, 2023

[TEP-0056]: Initial set of API refactors pertinent to Pipelines in Pipelines #7055

[TEP-0056]: Initial set of API refactors pertinent to Pipelines in Pipelines #7055

Conversation

bhujangr commented Aug 18, 2023 • edited by pritidesai Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Aug 18, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Aug 18, 2023

pritidesai commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

pritidesai commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

bhujangr commented Aug 18, 2023 • edited Loading

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

tekton-robot commented Aug 18, 2023

pritidesai Aug 23, 2023

Choose a reason for hiding this comment

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

pritidesai commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

tekton-robot commented Aug 25, 2023

JeromeJu commented Sep 5, 2023

tekton-robot commented Sep 5, 2023

tekton-robot commented Sep 5, 2023

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Sep 5, 2023

bhujangr commented Aug 18, 2023 •

edited by pritidesai

Loading

bhujangr commented Aug 18, 2023 •

edited

Loading