Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quickstart for configuring pipeline metrics levels #801

Merged
merged 2 commits into from
May 25, 2022
Merged

Add quickstart for configuring pipeline metrics levels #801

merged 2 commits into from
May 25, 2022

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented May 23, 2022 •
edited
Loading

Changes

Add Quickstart to guide the users to configure the pipeline metric level.

image

image

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

None

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 23, 2022
@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2022
@tekton-robot
Copy link
Contributor

Hi @karthikjeeyar. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor Author

/assign @nikhil-thomas

@sm43
Copy link
Member

sm43 commented May 24, 2022

/ok-to-test
/approve

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2022
@nikhil-thomas
Copy link
Member

/approve

@nikhil-thomas
Copy link
Member

@khrm

@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@nikhil-thomas
Copy link
Member

@karthikjeeyar could you fix these yaml lints

./cmd/openshift/operator/kodata/tekton-addon/optional/quickstarts/configure-pipeline-metrics-quickstart-yaml
  27:68     error    trailing spaces  (trailing-spaces)
  57:59     error    trailing spaces  (trailing-spaces)
  61:25     error    trailing spaces  (trailing-spaces)
  64:30     error    trailing spaces  (trailing-spaces)

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@khrm
Copy link
Contributor

khrm commented May 24, 2022

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@khrm
Copy link
Contributor

khrm commented May 24, 2022

Isn't this Quickstart encouraging a user to change the value to run level. Is this OK, @vdemeester?

@nikhil-thomas
Copy link
Member

Isn't this Quickstart encouraging a user to change the value to run level. Is this OK, @vdemeester?

@khrm
let us wait until we resolve this 🧑‍💻

fyi: the 2 cherry-picks merged already

@khrm
Copy link
Contributor

khrm commented May 24, 2022

@karthikjeeyar Will you add a disclaimer in this quickstart?

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@karthikjeeyar
Copy link
Contributor Author

@khrm I have added disclaimer in the QS as well and created patches for the same in 0.50.x, 0.55.x

#807
#808

@khrm
Copy link
Contributor

khrm commented May 25, 2022

/lgtm

@tekton-robot
Copy link
Contributor

@khrm: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor

khrm commented May 25, 2022

/test pull-tekton-operator-integration-tests

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, nikhil-thomas, sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khrm
Copy link
Contributor

khrm commented May 25, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@piyush-garg
Copy link
Contributor

/retest

@tekton-robot tekton-robot merged commit 5861901 into tektoncd:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@nikhil-thomas nikhil-thomas

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karthikjeeyar @tekton-robot @sm43 @nikhil-thomas @piyush-garg @khrm