-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quickstart for configuring pipeline metrics levels #801
Add quickstart for configuring pipeline metrics levels #801
Conversation
Hi @karthikjeeyar. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @nikhil-thomas |
/ok-to-test |
/approve |
/lgtm |
@karthikjeeyar could you fix these yaml lints ./cmd/openshift/operator/kodata/tekton-addon/optional/quickstarts/configure-pipeline-metrics-quickstart-yaml
27:68 error trailing spaces (trailing-spaces)
57:59 error trailing spaces (trailing-spaces)
61:25 error trailing spaces (trailing-spaces)
64:30 error trailing spaces (trailing-spaces) |
6e92ef9
to
c619c0e
Compare
/lgtm |
c619c0e
to
5300e19
Compare
/lgtm |
/hold |
Isn't this Quickstart encouraging a user to change the value to run level. Is this OK, @vdemeester? |
@khrm fyi: the 2 cherry-picks merged already |
@karthikjeeyar Will you add a disclaimer in this quickstart? |
/lgtm |
@khrm: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-tekton-operator-integration-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm, nikhil-thomas, sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/lgtm |
/retest |
Changes
Add Quickstart to guide the users to configure the pipeline metric level.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
None