-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/cluster tasks #655
Update/cluster tasks #655
Conversation
The following is the coverage report on the affected files.
|
9f454eb
to
b549cff
Compare
The following is the coverage report on the affected files.
|
b549cff
to
fafeefe
Compare
fafeefe
to
fb58dce
Compare
fb58dce
to
5a4a18c
Compare
The following is the coverage report on the affected files.
|
5a4a18c
to
85445a3
Compare
The following is the coverage report on the affected files.
|
85445a3
to
aaff3b1
Compare
The following is the coverage report on the affected files.
|
/approve |
aaff3b1
to
3843398
Compare
The following is the coverage report on the affected files.
|
/retest |
3843398
to
3978b46
Compare
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sm43, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3978b46
to
440b3dc
Compare
The following is the coverage report on the affected files.
|
/retest |
Remove non-localy maitained clusterTasks from OpenShift ClusterTasks in kodata Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Move locally maintained clustertasks into a `source-local` directorys within openshift kodata Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Move logic to create 'versioned clustertasks' (clustertasks with version suffix in names), into operator Move kind replacement of all tasks into operator Move tasks from (openshift) pipelines-catalog into operator openshift kodata Modify fetch clustertasks script to download tasks only from tektoncd/catalog repository main branch Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
440b3dc
to
3051190
Compare
The following is the coverage report on the affected files.
|
Add a config map to collect image replacement environmnent variables for openshift platform Add a script to find latest release tag of a step image, find its sha and replace it in openshift deploment files Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
3051190
to
c7274cb
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
1f1b458
to
1da9b21
Compare
Set `latest` as the default value for `VERSION` param in `s2i` Tasks Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
1da9b21
to
fee6f44
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Main Changes
move tasks from openshift/pipelines-catalog into openshift/kodata/../../source-local
use the fetch task script only to fetch task from tektoncd/catalog
use the fetch task script only to download the task into openshift/kodata/../../source-external (downloaded when along with other payload fetch)
operator changes the type of tasks in source-local and source-external from Task to ClusterTask just before installation
operator creates versioned versions of ClusterTasks during installation based on version information obtained from environment variable
Add image replacement environment variables for clusterTasks in operator controller deployment
Add a scrpt to find latest sha for latest releases of step images like buildah, s2i, skope-copy and kn
note: all tektoncd/catalog tasks are pulled from main branch. the version subfolder in the catalog organization should ensure the interface remains the same. The content of the tasks downloaded can be freezed per release branch.
Changes
[OpenShift] Improve Addon Task management
Move logic to create 'versioned clustertasks' (clustertasks with version
suffix in names), into operator
Move kind replacement of all tasks into operator
Move tasks from (openshift) pipelines-catalog into operator openshift
kodata
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes