Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tekton Chains to the operator #630

Merged
merged 10 commits into from
Mar 4, 2022
Merged

Add Tekton Chains to the operator #630

merged 10 commits into from
Mar 4, 2022

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Feb 23, 2022 •
edited
Loading

Add chains to the operator

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Add Tekton Chains to the operator

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 23, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 23, 2022
@piyush-garg piyush-garg mentioned this pull request Feb 23, 2022
Closed
9 tasks
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@piyush-garg
Copy link
Contributor Author

/retest

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.9% 41.3% -0.7
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 74.1%

sm43
sm43 reviewed Feb 28, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@piyush-garg
Copy link
Contributor Author

/retest

@sm43
Copy link
Member

sm43 commented Mar 3, 2022

/test pull-tekton-operator-integration-tests

@piyush-garg
Copy link
Contributor Author

/retest

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

1 similar comment
@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@piyush-garg
Copy link
Contributor Author

/retest

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

2 similar comments
@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@piyush-garg
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
concaf and others added 10 commits March 4, 2022 13:02
@concaf @piyush-garg
Add TektonChains types
8221292
@concaf @piyush-garg
Generated artifacts
9e111bf
@concaf @piyush-garg
Add Chains artifacts to the operator
8ef090f
@concaf @piyush-garg
Plug in chains to the operator
56e13bb
@piyush-garg
Update TektonChains reconciler logic
b829ffc 
This will update the tektonchains reconciler logic
for having better upgrades and making sure the existence of
only one installerset by having type in labels
@piyush-garg
Add e2e tests for chains
cd826b4
@piyush-garg
Fix the order of running e2e tests
2bb916d 
This will fix the order of running e2e tests as
config test should be run before component tests in common pkg

we need to run the tekton config first because other
tests remove the tektonconfig object
@piyush-garg
Use targetNamspace in place of tekton-chains
ceae816
@piyush-garg
Update chains CR create to get rid of polling
b799e01
@piyush-garg
Filter namespace if targetNamspace are same
c6fd995 
This will add a fix that if targetNamespace of pipeline and chains
are same so remove the namespace object from chains manifest as
the namespace will be already created and we dont need to
delete that if chains is deleted
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchains_lifecycle.go Do not exist 43.8%
pkg/apis/operator/v1alpha1/tektonchains_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/tektonchains_validation.go Do not exist 75.0%
pkg/reconciler/common/releases.go 41.3% 40.6% -0.6
pkg/reconciler/openshift/common/transformer.go 80.0% 81.2% 1.2
pkg/reconciler/shared/tektonconfig/chains/chains.go Do not exist 61.8%

@sm43
Copy link
Member

sm43 commented Mar 4, 2022

CI 🎉
/lgtm
/meow

@tekton-robot
Copy link
Contributor

@sm43: cat image

In response to this:

CI 🎉
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@tekton-robot tekton-robot merged commit f784bcb into tektoncd:main Mar 4, 2022
@piyush-garg piyush-garg mentioned this pull request Mar 7, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@savitaashture savitaashture savitaashture left review comments

@06kellyjac 06kellyjac 06kellyjac left review comments

@sm43 sm43 sm43 left review comments

@vdemeester vdemeester vdemeester approved these changes

@concaf concaf concaf approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@vdemeester vdemeester

@concaf concaf

@sm43 sm43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@piyush-garg @tekton-robot @sm43 @vdemeester @nikhil-thomas @concaf @savitaashture @06kellyjac