-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix autoprune not exectuing for second resource #38 #364
fix autoprune not exectuing for second resource #38 #364
Conversation
earlier resources["pipelinerun", "taskrun"] executes fine but somehow resources ["taskrun", "pipelinrun"] do not execute for the second resource. problem: command created and passed was an array where each item was treated as an arugement. Now the commands are single string and seperated by ';' Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
cc: @nikhil-thomas @sm43 |
@@ -151,11 +151,11 @@ func getPruningContainers(resources, namespaces []string, keep uint, tknImage st | |||
return containers | |||
} | |||
|
|||
func deleteCommand(resources []string, keep uint, ns string) []string { | |||
cmdArgs := []string{} | |||
func deleteCommand(resources []string, keep uint, ns string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a diff uint and int with respect to the downstream.
/lgtm |
Yes, it will delete a running pr/tr. |
@pradeepitm12 could you add an issue to track this case
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
earlier resources["pipelinerun", "taskrun"] executes fine
but somehow resources ["taskrun", "pipelinrun"] do not execute
for the second resource.
problem: command created and passed was an array where each
item was treated as an arugement.
Now the commands are single string and seperated by ';'
Signed-off-by: Pradeep Kumar pradkuma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes