Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HPA apiVersion #2250

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fix HPA apiVersion #2250

merged 1 commit into from
Jul 14, 2024

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jul 14, 2024 •
edited

this will fix the hpa apiVersion using deprecated
resource, move to v2 and spec accordingly

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fix HPA apiVersion

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 14, 2024
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2024
@savitaashture
Copy link
Contributor

this will fix the hpa apiVersion using deprecated resource, move to v1 and spec accordingly

Is it move to v2 and spec accordingly ??

@piyush-garg
Fix HPA apiVersion
12f4a4b 
this will fix the hpa apiVersion using deprecated
resource, move to v2 and spec accordingly
jkandasa
jkandasa approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jkandasa,savitaashture]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2024
@tekton-robot tekton-robot merged commit 4fef46a into tektoncd:main Jul 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa approved these changes

@savitaashture savitaashture savitaashture approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@jkandasa jkandasa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@piyush-garg @savitaashture @tekton-robot @jkandasa