Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Transformers for Results Configuration #1539

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix Transformers for Results Configuration #1539

merged 1 commit into from
Jun 5, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jun 5, 2023 •
edited
Loading

Changes

Results configurations wasn't being configured properly due to name and tag mismatch. This fixes that and add tests to cover that.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 5, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2023
khrm
khrm commented Jun 5, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 5, 2023
@khrm
Copy link
Contributor Author

khrm commented Jun 5, 2023

/cherry-pick release-v0.67.x

@tekton-robot
Copy link
Contributor

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.67.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.67.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 67.8% 66.7% -1.1

@piyush-garg
Copy link
Contributor

@khrm can you please add a description to the commit and PR

@khrm
Fix Transformers for Results Configuration
aa88dc2 
Results configurations wasn't being configured properly due to
name and tag mismatch. This fixes that and add tests to cover that.
@khrm khrm changed the title Fix Results Configuration Transformers Fix Transformers for Results Configuration Jun 5, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 67.8% 66.7% -1.1

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@tekton-robot tekton-robot merged commit 1512fd9 into tektoncd:main Jun 5, 2023
@tekton-robot
Copy link
Contributor

@khrm: new pull request created: #1540

In response to this:

/cherry-pick release-v0.67.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jun 5, 2023
Merged
@khrm khrm deleted the f/resultConf branch June 7, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @piyush-garg @jkandasa