-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep inspection for materials #903
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
tr := pro.GetTaskRunFromTask(t.Name) | ||
// Ignore Tasks that did not execute during the PipelineRun. | ||
if tr == nil || tr.Status.CompletionTime == nil { | ||
logger.Infof("taskrun status not found for task %s", t.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log message is probably not very helpful, and it's maybe a little misleading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. PTAL. Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Step 2/2 of tektoncd#850 Add deep inspection for materials, which will be applied to both slsa v0.2 and slsa v1.0 provenance. Signed-off-by: Chuang Wang <chuangw@google.com>
The following is the coverage report on the affected files.
|
/lgtm |
Changes
/kind feature
Step 2/2 of #850. Step 1 is available here
Add deep inspection for materials, which will be applied to both slsa v0.2 and slsa v1.0 provenance.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes