Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Update to sphinx-design 0.6.0 #86

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Jun 18, 2024

Problem

Proposal

Just a trial-and-error attempt. Completely untested. wdyt?

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (d74b0e3) to head (d6b8827).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files          10       10           
  Lines         588      588           
=======================================
  Hits          557      557           
  Misses         31       31           
Flag Coverage Δ
unittests 94.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,6 +1,11 @@
# Change Log

## Unreleased
- Dependencies: Update to sphinx-design 0.6.0
See also [sphinx-design change log].
- Remove support for Python 3.7 and 3.8, following `sphinx-design`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a drawback. Some projects at https://github.com/crate will probably still need Python 3.8.

@amotl amotl requested review from msbt and matkuliak June 18, 2024 21:08
@amotl amotl marked this pull request as ready for review June 18, 2024 21:11
@amotl amotl merged commit 4fd3b26 into main Jun 27, 2024
5 checks passed
@amotl amotl deleted the amo/sphinx-design-0.6 branch June 27, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant