Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-completion: fix issue with [.md, add basic -L completion, remove extra _files args #168

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

cho-m
Copy link

@cho-m cho-m commented Mar 19, 2021

Changes information:

The following are output from ZSH 5.8 with locally built master branch.


Some errors shown with original completions:

  1. [.md:
    error-1

  2. Empty cache stderr:
    error-2


Output of ZSH with new completions

  1. No issue with [.md:
    output1

  2. Empty cache, no completions shown (ignore dimmed font due to zsh-autosuggestions plugin):
    output2

  3. Empty cache, flag completions after -:
    output3

Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 😄 Everything works as expected on my machine.

Having suggestions for the language seems like a good idea. I don't think there is a way to predict how to specify your language right now (should it be "de", or "deutsch" or "german") and completions would help with that. I don't think that it is a must-have though.

@dbrgn
Copy link
Collaborator

dbrgn commented Mar 21, 2021

Thanks @cho-m for the fix and @niklasmohrin for the review/test!

@dbrgn dbrgn merged commit 0716808 into tealdeer-rs:master Mar 21, 2021
@cho-m cho-m deleted the zsh-completion-bracket branch March 21, 2021 19:01
@baodrate baodrate mentioned this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

zsh completion issue due to new '[.md' page
3 participants