Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make http 429 and 206 codes return alive #106

Merged
merged 6 commits into from
Sep 18, 2020

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Sep 14, 2020

Added features

  • http 429 code retry option.
    The link-check library used to check links here have this option but it defaults to disabled. I added a CLI option (-r or --retry) and also the ability to add the option to the JSON config file.
  • option to define the http codes for which an alive status is returned. I did not only make 206 work, but any code and it's configurable. Default is 200 only.
    CLI option and JSON config options are available. In JSON the list of codes has to be an integer array, on the command line a list with values separated by commas.

Testing

  • test suite was updated to check for 206codes to be considered alive and for retry on 429 with a duration returned by headers.
  • no CLI test are already present in the library so I did not add any. Maybe a TODO...

Doc

  • CLI help updated
  • README updated

Related issues

This was referenced Sep 14, 2020
@NicolasMassart
Copy link
Contributor Author

NicolasMassart commented Sep 18, 2020

FYI I sent an email to the @tcort to know if he needs help on this project and if this can be reviewed.
If nothing happens next week I will merge in my own fork master.

@tcort is still here ;) Feature merged!

@NicolasMassart NicolasMassart self-assigned this Sep 18, 2020
@NicolasMassart NicolasMassart added the enhancement New feature request or implementation label Sep 18, 2020
@tcort tcort merged commit 9f50271 into tcort:master Sep 18, 2020
@NicolasMassart
Copy link
Contributor Author

Thanks @tcort !

@NicolasMassart
Copy link
Contributor Author

Update available for this PR in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Throttling Filter Based on Status Response
2 participants