Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Commit

Permalink
upgrade imagemin-pngquant
Browse files Browse the repository at this point in the history
  • Loading branch information
tcoopman committed Sep 3, 2019
1 parent 5b0bb8a commit 7c17dc2
Show file tree
Hide file tree
Showing 7 changed files with 146 additions and 101 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log
All notable changes to this project will be documented in this file.

## [6.0.0]

* upgrade imagemin-pngquant to 8.0.0 (version bump because of the api change => quality now is an array). For more info see: https://github.com/imagemin/imagemin-pngquant#quality

## [5.1.0]

* upgrade outdated packages (except imagemin-pngquant because this one has an api change)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ rules: [{
enabled: false,
},
pngquant: {
quality: '65-90',
quality: [0.65, 0.90],
speed: 4
},
gifsicle: {
Expand Down
61 changes: 47 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"imagemin-gifsicle": "^6.0.1",
"imagemin-mozjpeg": "^8.0.0",
"imagemin-optipng": "^7.0.0",
"imagemin-pngquant": "^6.0.0",
"imagemin-pngquant": "^8.0.0",
"imagemin-svgo": "^7.0.0",
"imagemin-webp": "^5.1.0"
},
Expand Down
25 changes: 13 additions & 12 deletions test/webpack1.config.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
'use strict';
var path = require('path');
var webpack = require('webpack');
"use strict";
var path = require("path");
var webpack = require("webpack");

var commonLoaders = [
{test: /.*\.(gif|png|jpe?g|svg|bmp|webp)$/i, loaders: [
'file?hash=sha512&digest=hex&name=[hash].[ext]',
'../index.js']},
{
test: /.*\.(gif|png|jpe?g|svg|bmp|webp)$/i,
loaders: ["file?hash=sha512&digest=hex&name=[hash].[ext]", "../index.js"]
}
];
var assetsPath = path.join(__dirname, 'public/assets');
var assetsPath = path.join(__dirname, "public/assets");

module.exports = [
{
entry: './test/app.js',
entry: "./test/app.js",
output: {
path: assetsPath,
filename: 'app.[hash].js'
filename: "app.[hash].js"
},
module: {
loaders: commonLoaders
Expand All @@ -23,11 +24,11 @@ module.exports = [
mozjpeg: {
quality: 65
},
pngquant:{
quality: "65-90",
pngquant: {
quality: [0.65, 0.9],
speed: 4
},
svgo:{
svgo: {
plugins: [
{
removeViewBox: false
Expand Down
75 changes: 39 additions & 36 deletions test/webpack2.config.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use strict';
var path = require('path');
var webpack = require('webpack');
"use strict";
var path = require("path");
var webpack = require("webpack");

var assetsPath = path.join(__dirname, 'public/assets');
var assetsPath = path.join(__dirname, "public/assets");

var loaderOptions = {
mozjpeg: {
quality: 65
},
pngquant:{
quality: "65-90",
pngquant: {
quality: [0.65, 0.9],
speed: 4
},
svgo:{
svgo: {
plugins: [
{
removeViewBox: false
Expand All @@ -33,44 +33,47 @@ var loaderOptions = {
webp: {
quality: 75
}
}
};

var fileLoaderOptions = {
hash: 'sha512',
digest: 'hex',
name: '[hash].[ext]'
}
hash: "sha512",
digest: "hex",
name: "[hash].[ext]"
};

module.exports = [
{
entry: './test/app.js',
entry: "./test/app.js",
output: {
path: assetsPath,
filename: 'app.[hash].js'
filename: "app.[hash].js"
},
module: {
rules: [{
test: /.*\.(gif|png|jpe?g|svg|webp)$/i,
use: [
{
loader: 'file-loader',
options: fileLoaderOptions
},
{
loader: require.resolve('../'),
options: loaderOptions
}
]
}, {
test: /\.bmp$/i,
use: [
{
loader: 'file-loader',
options: fileLoaderOptions
},
require.resolve('../') // loaderUtils.getOptions() returns null for this one
]
}]
rules: [
{
test: /.*\.(gif|png|jpe?g|svg|webp)$/i,
use: [
{
loader: "file-loader",
options: fileLoaderOptions
},
{
loader: require.resolve("../"),
options: loaderOptions
}
]
},
{
test: /\.bmp$/i,
use: [
{
loader: "file-loader",
options: fileLoaderOptions
},
require.resolve("../") // loaderUtils.getOptions() returns null for this one
]
}
]
}
}
];
77 changes: 40 additions & 37 deletions test/webpack4.config.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use strict';
var path = require('path');
var webpack = require('webpack');
"use strict";
var path = require("path");
var webpack = require("webpack");

var assetsPath = path.join(__dirname, 'public/assets');
var assetsPath = path.join(__dirname, "public/assets");

var loaderOptions = {
mozjpeg: {
quality: 65
},
pngquant:{
quality: "65-90",
pngquant: {
quality: [0.65, 0.9],
speed: 4
},
svgo:{
svgo: {
plugins: [
{
removeViewBox: false
Expand All @@ -33,45 +33,48 @@ var loaderOptions = {
webp: {
quality: 75
}
}
};

var fileLoaderOptions = {
hash: 'sha512',
digest: 'hex',
name: '[hash].[ext]'
}
hash: "sha512",
digest: "hex",
name: "[hash].[ext]"
};

module.exports = [
{
mode: 'production',
entry: './test/app.js',
mode: "production",
entry: "./test/app.js",
output: {
path: assetsPath,
filename: 'app.[hash].js'
filename: "app.[hash].js"
},
module: {
rules: [{
test: /.*\.(gif|png|jpe?g|svg|webp)$/i,
use: [
{
loader: 'file-loader',
options: fileLoaderOptions
},
{
loader: require.resolve('../'),
options: loaderOptions
}
]
}, {
test: /\.bmp$/i,
use: [
{
loader: 'file-loader',
options: fileLoaderOptions
},
require.resolve('../') // loaderUtils.getOptions() returns null for this one
]
}]
rules: [
{
test: /.*\.(gif|png|jpe?g|svg|webp)$/i,
use: [
{
loader: "file-loader",
options: fileLoaderOptions
},
{
loader: require.resolve("../"),
options: loaderOptions
}
]
},
{
test: /\.bmp$/i,
use: [
{
loader: "file-loader",
options: fileLoaderOptions
},
require.resolve("../") // loaderUtils.getOptions() returns null for this one
]
}
]
}
}
];

0 comments on commit 7c17dc2

Please sign in to comment.