More follow-up on closed Temporal tests PRs #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Philip, March 2022: This was originally Frank's PR tc39#3060. I did some reformatting, removed a test that didn't exercise the whole feature, and combined some duplicate tests with some existing tests.)
(Philip, March 2022: This was originally Frank's PR tc39#3059. I did some reformatting, removed duplicate tests, and combined with some existing tests.)
(Philip, March 2022: This was originally Frank's PR tc39#3058. I did some reformatting, removed duplicate tests, and combined with some existing tests.)
(Philip, March 2022: This was originally Frank's PR tc39#3057. I did some reformatting, removed duplicate tests, addressed the review comments that I left the first time around, and added some cases that I felt were not yet complete.)
(Philip, March 2022: This was originally Frank's PR tc39#3056. I did some reformatting, removed duplicate tests, and combined with some existing tests.)
rwaldron
approved these changes
Apr 4, 2022
| const cal = new Temporal.Calendar("iso8601"); | ||
|
|
||
| assert.deepEqual( | ||
| cal.mergeFields({ a: 1, b: 2, month: 7 }, { b: 3, c: 4 }), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3438, this was originally PRs #3056, #3057, #3058, #3059, #3060 by @FrankYFTang which were closed without being merged. I'm following up as promised. I rebased the PRs, added assertion messages, did some reformatting, and combined with some existing tests. In a few places I added more test cases.