Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Temporal.Calendar.prototype.dayOf* #3051

Merged
merged 6 commits into from
Aug 5, 2021
Merged

Add tests for Temporal.Calendar.prototype.dayOf* #3051

merged 6 commits into from
Aug 5, 2021

Conversation

FrankYFTang
Copy link
Contributor

rwaldron
rwaldron requested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the directory names.

@FrankYFTang
Copy link
Contributor Author

PTAL

@FrankYFTang
Copy link
Contributor Author

It might be hard to review the test based on the current spec text due to tc39/proposal-temporal#1641

@FrankYFTang
Copy link
Contributor Author

@jugglinmike I think I fulfull what you ask me to do from other PR
PTAL

@rwaldron rwaldron merged commit 1c722a8 into tc39:main Aug 5, 2021
@FrankYFTang FrankYFTang deleted the dayOf branch July 21, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato left review comments

@rwaldron rwaldron rwaldron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @rwaldron @ptomato