WIP: Create calendar record from calendar objects

When constructing a new Temporal object with a calendar object, eagerly
get all the calendar methods, and save them in a Record, which goes into
the Temporal object's [[CalendarRecord]] internal slot.

_For internal use of the intrinsic constructors only_, in the polyfill
constructors accept a calendar record object instead of a calendar object.
This has no observable effect on user code, because user code can never
obtain a calendar record object.

Still to do:
- spec text
- inconsistency introduced between e.g. the calendar records in the
  objects returned from pdt.toPlainDate() (same as pdt) and pdt.with()
  (different from pdt if Calendar.prototype was mutated since pdt was
  created)

See: #1294

.eslintrc.yml

@@ -93,12 +93,14 @@ overrides:
       - polyfill/test/TimeZone/**/*.js
       - polyfill/test/PlainYearMonth/**/*.js
       - polyfill/test/ZonedDateTime/**/*.js
+      - polyfill/test/helpers/*.js
       - polyfill/test/now/**/*.js
     globals:
       Temporal: readonly
       Test262Error: readonly
       assert: readonly
       verifyProperty: readonly
+      MINIMAL_CALENDAR_OBJECT: readonly
     # test262 code complies to a different coding style
     extends: 'eslint:recommended'
     rules:

polyfill/ci_test.sh

@@ -29,6 +29,8 @@ else
 fi
 if [ $threads -gt 8 ]; then threads=8; fi
 
+cp ./helpers/* ../test262/harness/
+
 test262-harness \
   -t $threads \
   -r json \

polyfill/lib/intl.mjs

@@ -12,7 +12,7 @@ import {
   ISO_MILLISECOND,
   ISO_MICROSECOND,
   ISO_NANOSECOND,
-  CALENDAR,
+  CALENDAR_RECORD,
   TIME_ZONE
 } from './slots.mjs';
 import { TimeZone } from './timezone.mjs';
@@ -278,7 +278,7 @@ function extractOverrides(temporalObj, main) {
     const isoYear = GetSlot(temporalObj, ISO_YEAR);
     const isoMonth = GetSlot(temporalObj, ISO_MONTH);
     const referenceISODay = GetSlot(temporalObj, ISO_DAY);
-    const calendar = ES.ToString(GetSlot(temporalObj, CALENDAR));
+    const calendar = ES.CalendarToString(GetSlot(temporalObj, CALENDAR_RECORD));
     if (calendar !== main[CAL_ID]) {
       throw new RangeError(
         `cannot format PlainYearMonth with calendar ${calendar} in locale with calendar ${main[CAL_ID]}`
@@ -295,7 +295,7 @@ function extractOverrides(temporalObj, main) {
     const referenceISOYear = GetSlot(temporalObj, ISO_YEAR);
     const isoMonth = GetSlot(temporalObj, ISO_MONTH);
     const isoDay = GetSlot(temporalObj, ISO_DAY);
-    const calendar = ES.ToString(GetSlot(temporalObj, CALENDAR));
+    const calendar = ES.CalendarToString(GetSlot(temporalObj, CALENDAR_RECORD));
     if (calendar !== main[CAL_ID]) {
       throw new RangeError(
         `cannot format PlainMonthDay with calendar ${calendar} in locale with calendar ${main[CAL_ID]}`
@@ -312,7 +312,7 @@ function extractOverrides(temporalObj, main) {
     const isoYear = GetSlot(temporalObj, ISO_YEAR);
     const isoMonth = GetSlot(temporalObj, ISO_MONTH);
     const isoDay = GetSlot(temporalObj, ISO_DAY);
-    const calendar = ES.ToString(GetSlot(temporalObj, CALENDAR));
+    const calendar = ES.CalendarToString(GetSlot(temporalObj, CALENDAR_RECORD));
     if (calendar !== 'iso8601' && calendar !== main[CAL_ID]) {
       throw new RangeError(`cannot format PlainDate with calendar ${calendar} in locale with calendar ${main[CAL_ID]}`);
     }
@@ -333,7 +333,7 @@ function extractOverrides(temporalObj, main) {
     const millisecond = GetSlot(temporalObj, ISO_MILLISECOND);
     const microsecond = GetSlot(temporalObj, ISO_MICROSECOND);
     const nanosecond = GetSlot(temporalObj, ISO_NANOSECOND);
-    const calendar = ES.ToString(GetSlot(temporalObj, CALENDAR));
+    const calendar = ES.CalendarToString(GetSlot(temporalObj, CALENDAR_RECORD));
     if (calendar !== 'iso8601' && calendar !== main[CAL_ID]) {
       throw new RangeError(
         `cannot format PlainDateTime with calendar ${calendar} in locale with calendar ${main[CAL_ID]}`
@@ -361,7 +361,7 @@ function extractOverrides(temporalObj, main) {
   }
 
   if (ES.IsTemporalZonedDateTime(temporalObj)) {
-    const calendar = ES.ToString(GetSlot(temporalObj, CALENDAR));
+    const calendar = ES.CalendarToString(GetSlot(temporalObj, CALENDAR_RECORD));
     if (calendar !== 'iso8601' && calendar !== main[CAL_ID]) {
       throw new RangeError(
         `cannot format ZonedDateTime with calendar ${calendar} in locale with calendar ${main[CAL_ID]}`

polyfill/lib/now.mjs

@@ -20,14 +20,16 @@ function instant() {
 function plainDateTime(calendarLike, temporalTimeZoneLike = timeZone()) {
   const timeZone = ES.ToTemporalTimeZone(temporalTimeZoneLike);
   const calendar = ES.ToTemporalCalendar(calendarLike);
+  const calendarRecord = ES.NewCalendarRecord(calendar);
   const inst = instant();
-  return ES.BuiltinTimeZoneGetPlainDateTimeFor(timeZone, inst, calendar);
+  return ES.BuiltinTimeZoneGetPlainDateTimeFor(timeZone, inst, calendarRecord);
 }
 function plainDateTimeISO(temporalTimeZoneLike = timeZone()) {
   const timeZone = ES.ToTemporalTimeZone(temporalTimeZoneLike);
   const calendar = ES.GetISO8601Calendar();
+  const calendarRecord = ES.NewCalendarRecord(calendar);
   const inst = instant();
-  return ES.BuiltinTimeZoneGetPlainDateTimeFor(timeZone, inst, calendar);
+  return ES.BuiltinTimeZoneGetPlainDateTimeFor(timeZone, inst, calendarRecord);
 }
 function zonedDateTime(calendarLike, temporalTimeZoneLike = timeZone()) {
   const timeZone = ES.ToTemporalTimeZone(temporalTimeZoneLike);