Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HostEnsureCanCompileStrings takes only one argument #367

Closed
mgaudet opened this issue Jun 3, 2022 · 5 comments · Fixed by #400
Closed

HostEnsureCanCompileStrings takes only one argument #367

mgaudet opened this issue Jun 3, 2022 · 5 comments · Fixed by #400
Assignees
@ptomato
Labels
bug

Comments

@mgaudet
Copy link

mgaudet commented Jun 3, 2022

In the main spec HostEnsureCanCompileStrings takes only one argument; in the ShadowRealm use in PerformShadowRealmEval, it's passed two.

Unclear exactly the intent here; I suspect this should just be two calls?
@caridy
Copy link
Collaborator

caridy commented Jun 3, 2022

Na' that's just it was recently changed in 262, we need to update the specs to catch up with tc39/ecma262#2670

@mgaudet
Copy link
Author

mgaudet commented Jun 3, 2022

Perfect :)

@caridy
Copy link
Collaborator

caridy commented Feb 5, 2024

@ptomato can we get the spec updated to reflect the latest from 262?

@nicolo-ribaudo
Copy link
Member

Maybe let's wait a bit here, until when tc39/ecma262#3222 is merged, since it touches the same AO.

@caridy
Copy link
Collaborator

caridy commented Feb 8, 2024

tc39/ecma262#3222 has consensus, and will be merged soon, right after that, we can fix this.

@caridy caridy added the bug label Feb 8, 2024
ptomato added a commit to ptomato/proposal-shadowrealm that referenced this issue Feb 15, 2024
@ptomato
Editorial: Adapt to new HostEnsureCanCompileStrings
4e87467 
As of tc39/ecma262#3222 the signature of
HostEnsureCanCompileStrings changed. This adapts to the new signature by
pulling in the latest version of ecma262-biblio and adding the missing
arguments.

Closes: tc39#367
@ptomato ptomato mentioned this issue Feb 15, 2024
Merged
caridy pushed a commit that referenced this issue Feb 16, 2024
@ptomato
Editorial: Adapt to new HostEnsureCanCompileStrings (#400)
8e951a7 
As of tc39/ecma262#3222 the signature of
HostEnsureCanCompileStrings changed. This adapts to the new signature by
pulling in the latest version of ecma262-biblio and adding the missing
arguments.

Closes: #367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Adapt to new HostEnsureCanCompileStrings ptomato/proposal-shadowrealm
4 participants
@caridy @ptomato @mgaudet @nicolo-ribaudo