Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Normative: Make TA.p.subarray return a length-tracking array if original TA is length-tracking and no end is provided #93

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Normative: Make TA.p.subarray return a length-tracking array if original TA is length-tracking and no end is provided #93

merged 1 commit into from
Mar 30, 2022

Conversation

syg
Copy link
Collaborator

@syg syg commented Feb 16, 2022 •
edited
Loading

Closes #91

@syg syg requested a review from marjakh February 16, 2022 21:55
@syg syg changed the title Make TA.p.subarray return a length-tracking array if original TA is length-tracking and no end is provided Normative: Make TA.p.subarray return a length-tracking array if original TA is length-tracking and no end is provided Mar 1, 2022
@marjakh
Copy link

marjakh commented Mar 2, 2022

I was thinking about this PR, related to the mental model "subarray constructs a new TA with the backing buffer of the old TA, and the parameters given".

-> Concluded that this behavior matches that mental model.

@syg
Copy link
Collaborator Author

syg commented Mar 22, 2022

Rendering of this PR here: https://tc39.es/proposal-resizablearraybuffer/pr-93.html#sec-%typedarray%.prototype.subarray

@jridgewell jridgewell mentioned this pull request Mar 30, 2022
Open
@syg
Copy link
Collaborator Author

syg commented Mar 30, 2022

This PR achieved consensus in the March 2022 TC39.

@syg syg merged commit 33caf49 into master Mar 30, 2022
@syg syg deleted the subarray-creates-auto-length-ta branch March 30, 2022 21:10
pull bot pushed a commit to jamlee-t/v8 that referenced this pull request Sep 13, 2022
@syg
[rab/gsab] Fix length-tracking handling in TA#subarray
36559d9 
The normative change in
tc39/proposal-resizablearraybuffer#93 changed
the behavior of TypedArray.prototype.subarray(begin, end) such that if
the receiver is a length-tracking TA and end is undefined, the result
TypedArray is also length-tracking.

This change reached consensus in the March 2022 TC39.

Bug: v8:11111
Change-Id: If1a84cc3134f3ce8046196d6cc36683b6996dec0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3888382
Commit-Queue: Marja Hölttä <marja@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83147}
syg added a commit to syg/test262 that referenced this pull request Sep 19, 2022
@syg
Fix resizable ArrayBuffer subarray tests
da97430 
This is from the normative change in
tc39/proposal-resizablearraybuffer#93, which
got consensus in the March 2022 TC39.
@syg syg mentioned this pull request Sep 19, 2022
Merged
syg added a commit to tc39/test262 that referenced this pull request Sep 20, 2022
@syg
Fix resizable ArrayBuffer subarray tests (#3671)
465cf4a 
This is from the normative change in
tc39/proposal-resizablearraybuffer#93, which
got consensus in the March 2022 TC39.
catamorphism pushed a commit to catamorphism/test262 that referenced this pull request Oct 4, 2022
@syg @catamorphism
Fix resizable ArrayBuffer subarray tests (tc39#3671)
8216b3e 
This is from the normative change in
tc39/proposal-resizablearraybuffer#93, which
got consensus in the March 2022 TC39.
catamorphism pushed a commit to catamorphism/test262 that referenced this pull request Oct 5, 2022
@syg @catamorphism
Fix resizable ArrayBuffer subarray tests (tc39#3671)
ac4fc4c 
This is from the normative change in
tc39/proposal-resizablearraybuffer#93, which
got consensus in the March 2022 TC39.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marjakh marjakh Awaiting requested review from marjakh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do you want TA.p.subarray to create length-tracking TAs?
2 participants
@syg @marjakh