Normative: Change from getters to method with get prefix name change #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Jan 25, 2023
FrankYFTang
changed the title
|
In 2023-01-31 TC39 meeting the concensus is merge PR 67 but not PR65 |
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Mar 21, 2023
pull bot
pushed a commit
to jamlee-t/v8
that referenced
this pull request
Apr 7, 2023
Add two flags and two counters One flag to stage/ship the Intl Locale API after tc39/proposal-intl-locale-info#67 One flag to remove the getters obsoleted by the PR67 Add two counters to measure the usage of these two Bug: v8:13834, v8:13835 Change-Id: Ic29ffe9b6114d6f5d46224817e7f38bb6147b9e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4355215 Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#86988}
This was referenced Apr 19, 2023
Merged
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Sep 13, 2023
Ms2ger
pushed a commit
to FrankYFTang/test262
that referenced
this pull request
Sep 13, 2023
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a competiting PR vs #65
we should only land one of them.