Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes due to stage 3 reviews to present in July 2023 #142

Closed
3 tasks
nicolo-ribaudo opened this issue May 19, 2023 · 2 comments
Closed
3 tasks

Changes due to stage 3 reviews to present in July 2023 #142

nicolo-ribaudo opened this issue May 19, 2023 · 2 comments

Comments

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented May 19, 2023

The bar for changes to the proposal is now high, but there are some changes that are either already part of the proposal spec or are planned. I will bring these up for consensus at the July TC39 meeting.

  • Collect all the attributes in dynamic import before validating them (Stage 3 reviews #137 (comment)). The difference between the old and the new behavior is currently not tested neither by test262 not by V8's tests, so regardless of what we decide we should add a test for this.
  • Remove the [no LineTerminator here] restriction before with. This was necessary with assert to avoid ASI ambiguities, but given that with is a reserved word we don't have this problem anymore. I noticed this wile implementing the proposal in Babel, and it has also been reported at No need for NLTH with with keyword #136.
  • Allow any LiteralPropertyName in import attributes keys, making with { 0: "a", 1n: "b" } syntactically valid. This is for consistency with objects, and thus with the dynamic import form. (Normative: Add Import Attributes ecma262#3057 (review))
@nicolo-ribaudo
Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo changed the title Changes due to stage 3 reviews to ask consensus for Changes due to stage 3 reviews to present in July 2023 Jun 16, 2023
@nicolo-ribaudo
Copy link
Member Author

Consensus on all these changes. However, after plenary I received this feedback from SpiderMonkey: #145

@nicolo-ribaudo nicolo-ribaudo unpinned this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant