Normative: Add Import Attributes #3057
Conversation
nicolo-ribaudo
added
normative change
|
@tc39/ecma262-editors Currently the only remaining condition for this proposal to be actually Stage 3 is the editorial review. It'd be great if you have time to do it :) |
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
43b46ec
to
891ceab
Compare
|
I pushed two more normative commits, that are oversights from the
|
|
PR updated to remove support for float and bigint literal keys, as per consensus in the TC39 2023-09 meeting. |
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
a8c7397
to
940fcb2
Compare
nicolo-ribaudo
removed
the
needs test262 tests
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
940fcb2
to
c14c38a
Compare
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
c14c38a
to
b175092
Compare
|
PR updated to remove the @tc39/ecma262-editors I'd like to open a PR for https://tc39.es/proposal-json-modules/, which I plan to propose for stage 4 at the next meeting. The PR for that proposal needs to be based on top of this one. Guy would also like to rebase #3094 on top of this PR. What approach do you prefer?
|
|
@nicolo-ribaudo I prefer 1 but 3 is also fine. |
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
b175092
to
282c013
Compare
|
It turns out I don't have push access to this repo. Could somebody (@michaelficarra? @ljharb?) push this PR's branch to this repo so I can open a PR targeting it? :) Or give me push access, I don't know what's the policy. |
|
I did it for you at https://github.com/tc39/ecma262/tree/import-attributes. |
* Add Import Attributes proposal * `npm run format` * Updates from review * Changes from review * Do not re-define ImportDeclaration * Add `assert` deprecated syntax to `export ... from` * Remove `[no LineTerminator here]` before `with` * Use optional symbols to reduce grammar * Update ImportEntries and ExportEntry to use ModuleRequest Records * Review from Michael * Replace AttributeKey with LiteralPropertyName * Separate ModuleRequest and LoadedModuleRequest fields * Validate attrs when lodaing deps and not when parsing * Merge `AssertClause` into `WithClause`, and fix missing SDOs * Fix type annotation * Simplify AttributesKeyword * Reviews * Review * Remove support for float and bigint literal keys * Update wording
nicolo-ribaudo
force-pushed
the
import-attributes
branch
from
282c013
to
b0c8b92
Compare
|
@jmdyck Done, thanks! |
This proposal (https://tc39.es/proposal-import-attributes/, https://github.com/tc39/proposal-import-attributes) reached stage 3 during the March 2023 meeting, conditional on stage 3 reviews. I'm opening this PR before "real" stage 3 to help editors reviewing the full spec changes.
The proposal has already been integrated in HTML: https://html.spec.whatwg.org/#hostloadimportedmodule
PREVIEW: https://ci.tc39.es/preview/tc39/ecma262/pull/3057
DIFF: https://arai-a.github.io/ecma262-compare/?pr=3057 (note: the diff doesn't mark deprecated sections)