Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Fix an error in the logResult example code #540

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

matsilva
Copy link
Contributor

@matsilva matsilva commented Aug 8, 2024

Summary
This pull request makes a simple fix to the example logResult code.

Changes

  • Lifted result variable outside the try block scope
  • Updated the catch block to log the error **

** Alternatively to logging the error, it could log the result variable, which would be the value of undefined. Happy to do that, just let me know.

@matsilva
Copy link
Contributor Author

matsilva commented Sep 5, 2024

I do not have write access so I cannot merge. @tonivj5 would you be able to merge for me?

@tonivj5
Copy link

tonivj5 commented Sep 5, 2024

I do not have write access so I cannot merge. @tonivj5 would you be able to merge for me?

Sorry! I don't belongs to the proposals itself, I look at your changes and I liked them... 😅

@pzuraq pzuraq merged commit 8936bfe into tc39:master Sep 5, 2024
@pzuraq
Copy link
Collaborator

pzuraq commented Sep 5, 2024

Thank you! And sorry for the delayed response!

@matsilva matsilva deleted the patch-1 branch September 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants