-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Adds change-array-by-copy #2997
Conversation
Rather than leaving 'suggested change' comments here, I've submitted a PR against this PR's branch: acutmore#2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
9fa4edd
to
b59c42a
Compare
This proposal is now Stage 4: tc39/proposals@ad4df84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than typo.
5a1df73
to
269c803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are some opportunities I noticed to use our new interval notation, but I'm not sure what our editorial stance is on that at the moment, so this is fine as-is.
Co-authored-by: Ashley Claymore <aclaymore@bloomberg.net> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Robin Ricard <rricard2@bloomberg.net> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org> Co-authored-by: Shu-yu Guo <syg@chromium.org> Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: Linus Groh <mail@linusgroh.de>
82a40c9
to
4a32716
Compare
During review of PR tc39#2997, @michaelficarra suggested changing: > the intrinsic object listed in column one of {Table 68} for _exemplar_.[[TypedArrayName]] to: > the intrinsic object associated with the constructor name _exemplar_.[[TypedArrayName]] in {Table 68} in the new AO TypedArrayCreateSameType. (tc39#2997 (review)) This commit makes the same change in the pre-existing AO TypedArraySpeciesCreate.
During review of PR tc39#2997, @michaelficarra suggested changing: > the intrinsic object listed in column one of {Table 68} for _exemplar_.[[TypedArrayName]] to: > the intrinsic object associated with the constructor name _exemplar_.[[TypedArrayName]] in {Table 68} in the new AO TypedArrayCreateSameType. (tc39#2997 (review)) This commit makes the same change in the pre-existing AO TypedArraySpeciesCreate.
Stage 4 spec for https://github.com/tc39/proposal-change-array-by-copy