Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Split the "TV and TRV" clause into 2 clauses #2375

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Apr 6, 2021

... one for TV and one for TRV.

(This duplicates 4 cases, but they're very simple.)

In the status quo rendering, uses of TV and TRV aren't autolinked. With this change, they are.

Alternatively, @bakkot suggested having the two new clauses nested within the current clause 12.8.6.1, with the prose (and the final NOTE?) remaining in 12.8.6.1. I can do it that way if the editors prefer.

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakkot suggested having the two new clauses

No idea why I suggested that. The approach in this PR seems fine.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 28, 2021
... one for TV and one for TRV.

(This duplicates 4 cases, but they're very simple.)
@ljharb ljharb merged commit 39a1ed5 into tc39:master Jul 28, 2021
@jmdyck jmdyck deleted the TV_and_TRV branch July 29, 2021 00:23
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
... one for TV and one for TRV.

(This duplicates 4 cases, but they're very simple.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants