Editorial: Inline "Dynamic Function SourceText Prefixes" table #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Apr 3, 2021
There was a problem hiding this comment.
I like this approach, though we shouldn't land without discussing with @michaelficarra per this comment.
michaelficarra
approved these changes
Apr 8, 2021
ljharb
force-pushed
the
master
branch
3 times, most recently
from
3d0c24c
to
7a79833
Compare
jmdyck
force-pushed
the
CreateDynamicFunction_prefix
branch
from
b35fe87
to
ac675ad
Compare
|
force-pushed to:
|
bakkot
added
the
ready to merge
…2367) ... into the if-else cascade in CreateDynamicFunction, suggested in tc39#2348 (comment)
ljharb
force-pushed
the
CreateDynamicFunction_prefix
branch
from
ac675ad
to
6ca50dc
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
…2367) ... into the if-else cascade in CreateDynamicFunction, suggested in tc39#2348 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... into the if-else cascade in CreateDynamicFunction, as @bakkot suggested here