Update conway-game-of-life.md #57
Conversation
I cleaned up the code
|
👍 A big clean up. Thanks! This is looking good. I will later run the example in dev environment and merge your pull request. |
|
I playing with GitHubs review features. In case you receive too much comments or so... |
| const range = R.range | ||
| const without = R.without | ||
| const values = R.values | ||
| const prop = R.prop | ||
| const root = document.getElementById('GameOfLife') |
There was a problem hiding this comment.
The HTML element with ID #GameOfLife doesn't exist. So either change it to document.body or add a minimal HTML code snippet with the ID you selected. Example see here: https://github.com/tbreuss/mithril-by-examples/blob/main/examples/tweeter-box.md#markup
|
That's a good suggestion. I was wondering how intuitive it actually was to someone who was new to the concept - ill update it when I get some free time with a starting scene and some comments 👍🏼 |
Great! Thank you for your contribution. And keep coding in Mithril 😄 |
I cleaned up the code