Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stripe webhook url generated #42

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

philipxyc
Copy link
Contributor

It is highly recommended to keep the stripe callback URL a secret. Thus it is important to make the URL generated, so that every deployment of the website will get a different URL.

This change also included a minor adjustment on the stripe setting page to move the Publication key field before the Secret key, which preserves the order it shows on stripe console.

image

@sampoyigi
Copy link
Member

Instead of this approach we should implement stripe's signing secret.

@philipxyc
Copy link
Contributor Author

philipxyc commented Sep 3, 2022

Hey Sam, thanks for the reply. I absolutely agree with your idea of implementing stripe's signing secret, but I may not have time to implement this recently. Under this circumstance, the current approach to making the callback URL radom should buy us some more security levels before the signing secret is implemented.

@sampoyigi
Copy link
Member

Not an issue. I'll should have some free time this week to implement

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
@sampoyigi sampoyigi merged commit 093ab32 into tastyigniter:master Oct 21, 2022
@sampoyigi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants