Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enable default-tls unconditionally #554

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

ia0
Copy link
Collaborator

@ia0 ia0 commented Feb 13, 2024

This reverts 4be1d1e and make it more convenient to build taplo-common without explicitly providing a feature.

Fixes #553

@ia0 ia0 requested a review from JounQin February 13, 2024 15:38
@JounQin
Copy link
Collaborator

JounQin commented Feb 13, 2024

Package versions should be updated at the same time? Or would you work on another PR for releasing?

@ia0
Copy link
Collaborator Author

ia0 commented Feb 13, 2024

Package versions should be updated at the same time? Or would you work on another PR for releasing?

If I can avoid dealing with the release process I would prefer. I don't have too much time to invest. And actually before releasing it would probably be nice to update the Cargo.lock file to stop using yanked versions.

warning: package `ahash v0.7.6` in Cargo.lock is yanked in registry `crates-io`, consider running without --locked
warning: package `ahash v0.8.3` in Cargo.lock is yanked in registry `crates-io`, consider running without --locked
warning: package `crossbeam-channel v0.5.6` in Cargo.lock is yanked in registry `crates-io`, consider running without --locked

This reverts 4be1d1e and make it more
convenient to build taplo-common without explicitly providing a feature.
@JounQin JounQin merged commit ea13c5d into tamasfe:master Feb 14, 2024
4 checks passed
@ia0 ia0 deleted the tls branch February 14, 2024 09:05
Daniel-Aaron-Bloom added a commit to Daniel-Aaron-Bloom/taplo that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why was default-tls unconditionally enabled for reqwest?
2 participants