Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call onClose when Portal is actually closed #96

Closed
wants to merge 1 commit into from
Closed

Only call onClose when Portal is actually closed #96

wants to merge 1 commit into from

Conversation

Andreyco
Copy link

Fixes #95

@tajo
Copy link
Owner

tajo commented Dec 29, 2016

I want to merge this. Could you please add an test checking this behaviour and resolve conflicts? Thanks!

@mzygmunt
Copy link

Ohh is there any chance to merge this patch?

@Andreyco
Copy link
Author

Sorry, somehow I missed the comment where about express will to merge...
Will add tests and resolve conflicts asap.

@mzygmunt
Copy link

Thanks for quick response.

@likerRr
Copy link

likerRr commented Jul 21, 2017

@Andreyco any updates on tests?

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version (complete rewrite) of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

If you feel your PR still applies, please rebase it against the master and re-open it. Sorry for the lack of response in past! Thanks!

@tajo tajo closed this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants