Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for portal targets + fix conflicts & CI #123

Closed
wants to merge 6 commits into from

Conversation

Hypnosphi
Copy link

This is a fix for #100

@robinfehr
Copy link

robinfehr commented Jan 13, 2017

thank you! 👍

@kevinahuber
Copy link

This is great! 👍

@princed
Copy link

princed commented Jan 26, 2017

@tajo Is there a chance it could be merged?

@davideickhoff
Copy link

any new plans for merging?

@princed
Copy link

princed commented Apr 18, 2017

In the meanwhile, feel free to use our scoped package (https://github.com/Hypnosphi/react-portal/tree/scoped). No warranties whatsoever.

@arronhunt
Copy link

Bumping for this one

@Hypnosphi
Copy link
Author

I've rebased our branch to fit into the new project structure

@ablamunits
Copy link

ablamunits commented Sep 4, 2017

@Hypnosphi Thank you for this, I am using this off of your forked repo.
@tajo Any chance this will be merged here? Could be awesome.

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version (complete rewrite) of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

If you feel your PR still applies, please rebase it against the master and re-open it. Sorry for the lack of response in past! Thanks!

@tajo tajo closed this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants