-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality for portal targets + fix conflicts & CI #123
Conversation
thank you! 👍 |
This is great! 👍 |
@tajo Is there a chance it could be merged? |
any new plans for merging? |
In the meanwhile, feel free to use our scoped package (https://github.com/Hypnosphi/react-portal/tree/scoped). No warranties whatsoever. |
Bumping for this one |
I've rebased our branch to fit into the new project structure |
@Hypnosphi Thank you for this, I am using this off of your forked repo. |
Hey, please check the new major version (complete rewrite) of react-portal: #157 It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks. If you feel your PR still applies, please rebase it against the master and re-open it. Sorry for the lack of response in past! Thanks! |
This is a fix for #100