Fix transition and focus prop combination for PopoverPanel component
#3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/issue-3358
branch
from
09fa658
to
1245b1e
Compare
thecrypticace
approved these changes
Jul 4, 2024
This was referenced Jul 27, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the combination of the
focusandtransitionprop on thePopoverPanelcomponent didn't work as expected.The issue is that we moved focus inside the
PopoverPanelin an effect, and we relied on auseRefto get access to thePopoverPanelDOM node. However, due to the transition, this ref wasn't filled in. The moment the ref is filled in, it's too late and the effect doesn't re-run anymore.Instead, we rely on the DOM element that's coming from state. This one is updated and will re-render the component because we update the state when the ref is available.
Fixes: #3358