Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging tests when using anchor prop #3357

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Fix hanging tests when using anchor prop #3357

merged 6 commits into from
Jul 3, 2024

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Jul 3, 2024

This PR fixes an issue where your tests could hang (due to an infinite loop) when testing components using the anchor prop in a JSDOM based environment.

The issue that we were causing an infinite loop because some computation ended up resulting in NaN. There is also a very elegant purely CSS based solution (using round()) to the underlying problem, but it just got support in Chrome, so for now we will just fix the issue.

Fixes: #3339
Fixes: #3294

Testing using this playground example, so cleaned it up to be more
modern using newer components, transition prop and so on.
Let's make it a CSS problem instead of a JS problem. The
`round(up, <valueToRound>, <roundingInterval>)` will behave similar to a
`Math.ceil()` that we had in the JS implementation.

See: https://developer.mozilla.org/en-US/docs/Web/CSS/round
I want to re-enable this in the future, but unfortunately for now we
can't use it because Chrome only introduced support for this in the last
2 months.

This reverts commit daac60d45ec3f02b324d0d8b18078a995e885733.
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 0:54am
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 0:54am

let maxHeight = element.style.maxHeight
if (parseFloat(maxHeight) !== parseInt(maxHeight)) {
element.style.maxHeight = `${Math.ceil(parseFloat(maxHeight))}px`
let maxHeight = window.getComputedStyle(element).maxHeight
Copy link
Member Author

@RobinMalfait RobinMalfait Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used getComputedStyle to resolve the calculated min(var(--anchor-max-height, 100vh), ${availableHeight}px) value

@RobinMalfait RobinMalfait merged commit 70f88f4 into main Jul 3, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-3339 branch July 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants