Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ComboboxInput does not sync while you are still typing #3259

Merged
merged 4 commits into from
May 31, 2024

Commits on May 31, 2024

  1. track isTyping in state

    While you are typing, we should not sync the value with the `<input>`
    because otherwise it would override your changes.
    
    The moment you close the Combobox (by selecting an option, clicking
    outside, pressing escape or tabbing away) we can mark the component as
    not typing anymore. Once you are not typing anymore, then we can re-sync
    the input with the given value.
    RobinMalfait committed May 31, 2024
    Configuration menu
    Copy the full SHA
    47bae27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    174872d View commit details
    Browse the repository at this point in the history
  3. require isTyping boolean

    RobinMalfait committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4c88271 View commit details
    Browse the repository at this point in the history
  4. update changelog

    RobinMalfait committed May 31, 2024
    Configuration menu
    Copy the full SHA
    74eea6a View commit details
    Browse the repository at this point in the history