Keep <Combobox /> open when clicking in scrollbar on <ComboboxOptions>
#3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/issue-3230
branch
from
3d03601
to
0e37048
Compare
thecrypticace
approved these changes
May 28, 2024
adamwathan
reviewed
May 28, 2024
packages/@headlessui-react/src/components/combobox/combobox.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wathan <adam.wathan@gmail.com>
Co-authored-by: Adam Wathan <adam.wathan@gmail.com>
This was referenced Jul 13, 2024
This was referenced Jul 27, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 10, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a
<Combobox>would close if you click inside the scrollbar area on the<ComboboxOptions>. This is because clicking inside the scrollbar area performs a click on the element below the scrollbar (at least on macOS). If the element below is focusable, then focus will be moved there.If focus is moved to the underlying element, then the
<ComboboxInput>will blur which causes the<Combobox>will close.This issue can be seen in #3230 where using the
<Combobox>inside the<Dialog>then clicking in the scrollbar area of the<ComboboxOptions>will move the focus to the<Dialog>itself and closes the<Combobox>.Fixes: #3230