Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure data-disabled is available on virtualized options #3128

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Make sure data-disabled is available on virtualized options #3128

merged 4 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Make sure data-disabled is available on virtualized options

    @thecrypticace
    thecrypticace committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c4ac120 View commit details
    Browse the repository at this point in the history

  2. Add test

    @thecrypticace
    thecrypticace committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0d72278 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @thecrypticace
    thecrypticace committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b84128c View commit details
    Browse the repository at this point in the history

  4. calculate disabled state once 

    This way we only have to calculate it once and we can re-use that
information throughout the component. If the `value` changes of the
option, then the component has to re-render anyway which will re-compute
the `disabled` state.
    @RobinMalfait
    RobinMalfait committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ef85084 View commit details
    Browse the repository at this point in the history