Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frozen value to ComboboxOptions component #3126

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Add frozen value to ComboboxOptions component #3126

merged 4 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. add frozen state to Combobox component 

    Once you choose an option, the `selected` state remains on the "old"
value until the combobox is fully closed. This way the potential visual
indicators such as a check mark doesn't move around while the Combobox
is closing (when using transitions)

Same as the `Listbox`, this is purely about visual state and exposed
data from the `ComboboxOptions` component and down that tree. The
top-level `Combobox` and `ComboboxInput` components still know the
correct (new) value and will update the `aria-activedescendant`
correctly.

This is achieved by storing the old data (only in single value mode),
and overriding the `isSelected` check function via context provided by
the `ComboboxOptions` component.
    @RobinMalfait
    RobinMalfait committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4f6c207 View commit details
    Browse the repository at this point in the history

  2. remove check that verified that no aria-selected was present 

    But now with this change, it will be present.
    @RobinMalfait
    RobinMalfait committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    db56879 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    30c6d5a View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @RobinMalfait
    RobinMalfait committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c0d1f4b View commit details
    Browse the repository at this point in the history