Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure children prop of Field component can be a render prop #2941

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

RobinMalfait
Copy link
Member

This PR ensures that the Field can be used using a render prop as the children of the Field component.

This means that we can now do this again:

<Field>
  {({ disabled }) => {
    return <input className={disabled ? "..." : "..."} />;
  }}
</Field>

This normally works in every component, but it was missing because we were manually wrapping the children in a component and forgot to handle this case.

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 0:59am
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 0:59am

@RobinMalfait RobinMalfait merged commit ce17c6d into main Jan 23, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/field-render-prop branch January 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant