Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aarch64: Support run-time detection of FEAT_LSE on Windows #63

Merged
merged 1 commit into from
Jan 24, 2023
Merged

aarch64: Support run-time detection of FEAT_LSE on Windows #63

merged 1 commit into from
Jan 24, 2023

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jan 23, 2023 •
edited
Loading

As of nightly-2023-01-23, is_aarch64_feature_detected doesn't support run-time detection of FEAT_LSE on Windows.

A patch on stdarch side: rust-lang/stdarch#1373

@taiki-e taiki-e added the O-arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state label Jan 23, 2023
@taiki-e taiki-e force-pushed the aarch64-windows branch 5 times, most recently from 6d95c56 to 44e6a3b Compare January 24, 2023 14:39
@taiki-e
Copy link
Owner Author

taiki-e commented Jan 24, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

Build succeeded:

@bors bors bot merged commit e5463e2 into main Jan 24, 2023
@bors bors bot deleted the aarch64-windows branch January 24, 2023 16:55
@taiki-e taiki-e mentioned this pull request Jan 25, 2023
Merged
@taiki-e taiki-e changed the title aarch64: Support detecting FEAT_LSE on Windows aarch64: Support run-time detection of FEAT_LSE on Windows Jan 25, 2023
bors bot added a commit that referenced this pull request Jan 26, 2023
@bors @taiki-e
Merge #64
ca6032b 
64: detect: Support run-time detection of FEAT_LSE on aarch64 OpenBSD r=taiki-e a=taiki-e

As of nightly-2023-01-23, is_aarch64_feature_detected doesn't support run-time detection of FEAT_LSE on OpenBSD.

This patch also supports run-time detection of FEAT_LSE on aarch64 FreeBSD without "std" feature.

This patch also adds preliminary support for run-time detection of FEAT_LSE2 and FEAT_LSE128. This is currently only used in tests but will be used in the library in the future.

~~As well as #63, I will send a patch to stdarch later.~~ Filed rust-lang/stdarch#1374.

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e taiki-e mentioned this pull request Jan 28, 2023
Merged
This was referenced Feb 9, 2023
Merged
Merged
taiki-e added a commit that referenced this pull request Feb 12, 2023
@taiki-e
detect: Remove use of is_aarch64_feature_detected
f53ae5d 
This removes the use of `is_aarch64_feature_detected`. (As of nightly-2023-02-08, we already support all targets supported by `is_aarch64_feature_detected`, plus more. Some of them have already been upstreamed such as #63 and #64, they will be available in the future nightly.)
taiki-e added a commit that referenced this pull request Feb 12, 2023
@taiki-e
detect: Remove use of is_aarch64_feature_detected
6cb8d30 
This removes the use of `is_aarch64_feature_detected`. (As of nightly-2023-02-08, we already support all targets supported by `is_aarch64_feature_detected`, plus more. Some of them have already been upstreamed such as #63 and #64, they will be available in the future nightly.)
@taiki-e taiki-e added O-aarch64 Target: Armv8-A, Armv8-R, or later processors in AArch64 mode and removed O-arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels Sep 2, 2024
@taiki-e taiki-e mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
O-aarch64 Target: Armv8-A, Armv8-R, or later processors in AArch64 mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e