Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note for overlapping lists #647

Merged
merged 2 commits into from
Sep 25, 2023
Merged

add note for overlapping lists #647

merged 2 commits into from
Sep 25, 2023

Conversation

dev-ardi
Copy link
Contributor

@dev-ardi dev-ardi commented Sep 15, 2023

dev-ardi and others added 2 commits September 25, 2023 01:13
Sometimes I need to make a link to the basics, but until that I did not have it
Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly updated PR, added a reference to the feature that was possible after merging #649. If all wording are correct, it can be merged. @dralley , are you willing to check?

@codecov-commenter
Copy link

Codecov Report

Merging #647 (d6d8abd) into master (7866cf1) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   64.47%   64.51%   +0.04%     
==========================================
  Files          36       36              
  Lines       17315    17286      -29     
==========================================
- Hits        11163    11152      -11     
+ Misses       6152     6134      -18     
Flag Coverage Δ
unittests 64.51% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/de/mod.rs 69.41% <0.00%> (+0.37%) ⬆️

Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. It's phrased a little weirdly but it's perfectly understandable. I've stopped trying to point out every little grammar glitch because it's just not a big deal anyway.

@Mingun Mingun merged commit ad7553b into tafia:master Sep 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants