Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Lock down conf file permissions to 644 #106

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

jhanggi
Copy link
Contributor

@jhanggi jhanggi commented Feb 21, 2019

No description provided.

Copy link
Contributor

@pturley pturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks correct to me, but I will let @phoolish or @vandrijevik be the real approver. I dont know this code super well.

Copy link

@vandrijevik vandrijevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I might change the test name to say something about the executability bit (since these files are not executable, and to me that’s the real fix) but go with your ❤️!

@jhanggi
Copy link
Contributor Author

jhanggi commented Feb 22, 2019

@phoolish I'll probably need some help getting this rolled out. I don't know all the steps that'll be involved to get it into core env and then the main repo.

@vandrijevik
Copy link

@jhanggi When you merge this PR into master, a new release of the nginx_conf cookbook will be released to our Chef server. Afterwards, in chef-core_env (which depends on the cookbook) you can run bundle exec berks update nginx_conf, which will pick up the new version and update Berksfile.lock.

Finally, when you merge the PR for that update in chef-core_env, it will first update core_staging, and after manually approving that workflow in CircleCI, the change will propagate to core_production.

Hope that helps!

@jhanggi jhanggi merged commit d655355 into master Feb 25, 2019
@jhanggi jhanggi deleted the lock_down_conf_file_permissions branch February 25, 2019 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants