encourage to use sensor.scaleTo instead Fn.map #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
requested changes
Aug 30, 2019
|
|
||
| // `this.value` will reflect a scaling from 0-1023 to 0-179 | ||
| servo.to(this.value) | ||
| servo.to(pot.scaleTo(0, 179)) |
There was a problem hiding this comment.
Don't we need to use this.value here?
There was a problem hiding this comment.
No, isn't necessary.
In this solution this.value doesn't have the scaled value.
If we want to use this.value, like in the scale comment, I think we have to chain the scaleTo with the on change: pot.scaleTo(0, 179).on('change', ...)
ccarruitero
force-pushed
the
robot-arm
branch
from
a6cc0ad
to
0e96a45
Compare
|
@alanshaw I just updated the PR to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think will better encourage to use the api proposed by johnny-five (
sensor.scaleTo) instead an internal function likeFn.map.I removed the
scalecomment since is deprecated