Reduce noise caused by remote addresses having improper host/port combinations #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
requested changes
Mar 14, 2024
| @@ -45,7 +44,6 @@ func (h *HostRouter) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| host, _, err := net.SplitHostPort(raddr) | |||
| if err != nil { | |||
| logrus.Error(err) | |||
There was a problem hiding this comment.
if we're not reporting it to sentry then we also shouldn't be logging it at the error level. Please reduce this to debug.
turt2live
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not even two weeks and there is nothing to infer or fix from it, since it is mostly the misconfiguration of other people.