make fails with Error 2

[jaymot123]

I followed the instructions in the readme. I have the newest versions of SoapySDR and libacars installed. Cmake shows nothing wrong or missing. When I run make it says:

$ cmake ../
-- The C compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Build type not specified: defaulting to Release
-- Performing Test CC_HAS_PTHREAD
-- Performing Test CC_HAS_PTHREAD - Success
-- Performing Test CC_HAS_FFAST_MATH
-- Performing Test CC_HAS_FFAST_MATH - Success
-- Performing Test CC_HAS_FNO_COMMON
-- Performing Test CC_HAS_FNO_COMMON - Success
-- Looking for pthread_barrier_wait
-- Looking for pthread_barrier_wait - found
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29") 
-- Found liquid includes:	/usr/local/include/liquid/liquid.h
-- Found liquid library: /usr/local/lib/libliquid.so
-- Performing Test LIQUIDDSP_VERSION_CHECK
-- Performing Test LIQUIDDSP_VERSION_CHECK - Success
-- Checking for module 'fftw3f'
--   Found fftw3f, version 3.3.8
-- Checking for module 'glib-2.0'
--   Found glib-2.0, version 2.58.3
-- Checking for module 'libacars-2>=2.1.0'
--   Found libacars-2, version 2.1.3
-- Checking for module 'libconfig++'
--   Found libconfig++, version 1.5
-- Checking for SoapySDR
--   SoapySDR found, /usr/local/include, SoapySDR
-- Found SQLite3: /usr/include (found version "3.27.2") 
-- Checking for module 'libzmq>=3.2.0'
--   Found libzmq, version 4.3.1
-- dumphfdl configuration summary:
-- - SDR drivers:
--   - soapysdr:		requested: ON, enabled: TRUE
-- - Other options:
--   - Etsy StatsD:		requested: ON, enabled: TRUE
--   - SQLite:			requested: ON, enabled: TRUE
--   - ZeroMQ:			requested: ON, enabled: TRUE
--   - Profiling:		requested: OFF, enabled: FALSE
--   - Multithreaded FFT:	TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /home/jay/SDR_Apps/dumphfdl/build
jay@mxdesktop:~/SDR_Apps/dumphfdl/build
$ make
[  2%] Generating version.c, _version.c
Scanning dependencies of target dumphfdl_base
[  4%] Building C object src/CMakeFiles/dumphfdl_base.dir/ac_cache.c.o
[  7%] Building C object src/CMakeFiles/dumphfdl_base.dir/ac_data.c.o
[  9%] Building C object src/CMakeFiles/dumphfdl_base.dir/acars.c.o
[ 12%] Building C object src/CMakeFiles/dumphfdl_base.dir/block.c.o
[ 14%] Building C object src/CMakeFiles/dumphfdl_base.dir/cache.c.o
[ 17%] Building C object src/CMakeFiles/dumphfdl_base.dir/crc.c.o
[ 19%] Building C object src/CMakeFiles/dumphfdl_base.dir/fastddc.c.o
[ 21%] Building C object src/CMakeFiles/dumphfdl_base.dir/fft.c.o
[ 24%] Building C object src/CMakeFiles/dumphfdl_base.dir/fmtr-basestation.c.o
[ 26%] Building C object src/CMakeFiles/dumphfdl_base.dir/fmtr-text.c.o
[ 29%] Building C object src/CMakeFiles/dumphfdl_base.dir/globals.c.o
[ 31%] Building C object src/CMakeFiles/dumphfdl_base.dir/hfdl.c.o
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:205:2: error: unknown type name ‘modem’
  modem m[MODULATION_CNT];
  ^~~~~
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c: In function ‘hfdl_channel_create’:
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:479:17: warning: implicit declaration of function ‘modem_create’; did you mean ‘modemcf_create’? [-Wimplicit-function-declaration]
  c->m[M_BPSK] = modem_create(LIQUID_MODEM_BPSK);
                 ^~~~~~~~~~~~
                 modemcf_create
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c: In function ‘hfdl_channel_destroy’:
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:528:2: warning: implicit declaration of function ‘modem_destroy’; did you mean ‘modemcf_destroy’? [-Wimplicit-function-declaration]
  modem_destroy(c->m[M_BPSK]);
  ^~~~~~~~~~~~~
  modemcf_destroy
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c: In function ‘hfdl_decoder_thread’:
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:709:5: warning: implicit declaration of function ‘modem_demodulate’; did you mean ‘modemcf_demodulate’? [-Wimplicit-function-declaration]
     modem_demodulate(c->m[c->current_mod_arity], s, &bits);
     ^~~~~~~~~~~~~~~~
     modemcf_demodulate
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:710:33: warning: implicit declaration of function ‘modem_get_demodulator_phase_error’; did you mean ‘modemcf_get_demodulator_phase_error’? [-Wimplicit-function-declaration]
     costas_cccf_adjust(c->loop, modem_get_demodulator_phase_error(c->m[c->current_mod_arity]));
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                 modemcf_get_demodulator_phase_error
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c: In function ‘decode_user_data’:
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:979:2: error: unknown type name ‘modem’; did you mean ‘mode_t’?
  modem data_modem = c->m[c->data_mod_arity];
  ^~~~~
  mode_t
/home/jay/SDR_Apps/dumphfdl/src/hfdl.c:985:3: warning: implicit declaration of function ‘modem_demodulate_soft’; did you mean ‘modemcf_demodulate_soft’? [-Wimplicit-function-declaration]
   modem_demodulate_soft(data_modem, symbol * phase_flip[descrambler_bit] * phase_flip[c->bitmask & 1],
   ^~~~~~~~~~~~~~~~~~~~~
   modemcf_demodulate_soft
make[2]: *** [src/CMakeFiles/dumphfdl_base.dir/build.make:213: src/CMakeFiles/dumphfdl_base.dir/hfdl.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:133: src/CMakeFiles/dumphfdl_base.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

System is MX Linux 19.4 based on Debian Buster.

[jaymot123]

I forgot to say that I was previously able to build and install version 1.1.0 on this system. That was prior to installing the latest version of SoapySDR and the SDRPlay API for my new RSP1A which just arrived yesterday. I tried recompiling 1.1.0 and get the same error when running make. Edit: the file hfdl.c.o doesn't exist in /home/jay/SDR_Apps/dumphfdl/build/src/CMakeFiles/dumphfdl_base.dir/ I'm stumped, I have no idea what to look for.

[szpajder]

This:

-- Found liquid includes:	/usr/local/include/liquid/liquid.h
-- Found liquid library: /usr/local/lib/libliquid.so

suggests that it is using liquid-dsp library which has been installed manually from source. Which version is that? Maybe it's too old?

How about just using liquid 1.3.2 which is packaged in Buster?

[jaymot123]

Ah, that came from one of the build shell scripts that was provided by SDRPlay's website for other Linux distros. It installed the version on https://github.com/jgaeddert/liquid-dsp which is also 1.3.2. I'll see if I can figure out how to get that off of my system then (re)install the Buster package if need be. There's probably a conflict between two copies of LiquidDSP in two different locations.

[jaymot123]

/usr/local/include/liquid was an empty directory. I deleted it, reinstalled the Buster package just in case, deleted the files in the build directory, then reran cmake ../ and make followed by sudo make install and it built and runs. Thank you.

[szpajder]

The modem API in liquid-dsp has recently been changed in a backwards-incompatible manner and this is the cause of this problem.

I have filed an issue here: jgaeddert/liquid-dsp#273

[jaymot123]

What's even better, it's actually receiving messages! Wow! 👯‍♂️