fix: prevent division by zero in bezier #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UziTech
requested changes
Aug 23, 2024
samvimes01
force-pushed
the
fix/prevent-zero-division
branch
from
e3c8b33
to
c1ccc10
Compare
UziTech
approved these changes
Aug 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
## [5.0.3](v5.0.2...v5.0.3) (2024-08-23) ### Bug Fixes * prevent division by zero in bezier ([#785](#785)) ([1ca425e](1ca425e))
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases Bezier curve calculations could fail due to division by zero.
(for example when signature was generated by older version of the lib or another lib with similar approach to saving canvas data like this one http://keith-wood.name/signature.html)
This PR fixes the issue by checking for zero before the division.