Mergui updated #1
Comments
|
Awesome thanks @lenscas. Will look into updating :) |
|
One warning though: The CI seems to have broken on those 2 repo's. They where also not setup to work with wasm-bindgen (I never used that) and std-web seems to have broken in one of quicksilvers dependencies. So, though everything should still work, and I can see that locally native builds still do its hard to verify. Either way, if you run into issues just let me know and I'll see what I can do :) |
|
Hmm okay. I was hoping to target wasm. Any idea how much work would be involved with setting that up? |
|
you can still target wasm. Just seems that std-web isn't working out of the box anymore. Wasm-bindgen should still work, but as I already said I never used it. The plan was to move to wasm-bindgen in quicksilver anyway (ryanisaacg/quicksilver#653) and as std-web is both less popular and doesn't seem to get updates I would recommend to use that. I doubt that either Mergui or Silver_animation have problems with wasm-bindgen. The stdweb feature they both have just enables the quicksilver one. At the time when I wrote the CI for them I didn't know you could enable a feature in a dependency through the command line, so that is why they exist. |
|
Awesome sounds good. Thanks @lenscas
Thank you,
.
..: Raen
…________________________________
From: lenscas <notifications@github.com>
Sent: Saturday, November 28, 2020 11:59:04 AM
To: xipi2048/the_net <the_net@noreply.github.com>
Cc: Raen Herron <raen@quantumtrip.org>; Assign <assign@noreply.github.com>
Subject: Re: [xipi2048/the_net] Mergui updated (#1)
you can still target wasm. Just seems that std-web isn't working out of the box anymore. Wasm-bindgen should still work, but as I already said I never used it. The plan was to move to wasm-bindgen in quicksilver anyway (ryanisaacg/quicksilver#653<ryanisaacg/quicksilver#653>) and as std-web is both less popular and doesn't seem to get updates I would recommend to use that.
I doubt that either Mergui or Silver_animation have problems with wasm-bindgen. The stdweb feature they both have just enables the quicksilver one. At the time when I wrote the CI for them I didn't know you could enable a feature in a dependency through the command line, so that is why they exist.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJIQO6FWOY6TZEAN7Z67L3SSFJARANCNFSM4UF6UK6Q>.
|
|
Going to be trying mergui with my next project. Want to keep the dependencies down on this one |
It looked like you wanted to use Mergui with the latest version of quicksilver. I updated Mergui to target the latest quicksilver so it should be easier now. Just put
in the Cargo.toml file.
I did the same for silver_animation. To use it, put
in the Cargo.toml file.
The update(s) don't contain any other changes.
The text was updated successfully, but these errors were encountered: