Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: lto = "thin" #93

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Conversation

hswong3i
Copy link
Contributor

Refer to nabijaczleweli/systemd-zram-generator.deb@8f2f3fa, building package on Debian 10+ and Ubuntu 20.04+ will fail with lto = true.

Moreover, tested with https://build.opensuse.org/package/show/home:alvistack:systemd/zram-generator, lto = "thin" working well for all support OS, including CentOS/Fedora/Debian/Ubuntu/openSUSE.

Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com

Refer to <nabijaczleweli/systemd-zram-generator.deb@8f2f3fa>,
building package on Debian 10+ and Ubuntu 20.04+ will fail with `lto = true`.

Moreover, tested with
<https://build.opensuse.org/package/show/home:alvistack:systemd/zram-generator>,
`lto = "thin"` working well for all support OS, including
CentOS/Fedora/Debian/Ubuntu/openSUSE.

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@keszybz
Copy link
Member

keszybz commented Aug 8, 2021

Looking at https://doc.rust-lang.org/cargo/reference/profiles.html#lto, "thin" seems appropriate.

@keszybz
Copy link
Member

keszybz commented Aug 8, 2021

CI is failing when trying to load zram, i.e. lack of #92. Let's merge anyway.

@keszybz keszybz merged commit 17fc632 into systemd:main Aug 8, 2021
@hswong3i hswong3i deleted the main-cargo_toml branch August 9, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants