Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @theme-ui/css/utils with TypeScript CIF functions and fix preset types #1862

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Add @theme-ui/css/utils with TypeScript CIF functions and fix preset types #1862

merged 4 commits into from
Jul 27, 2021

Commits on Jul 27, 2021

  1. Define correct types in most presets. 

    Exported values in presets should have the correct types so they can be
used properly when imported. Define types for all the relatively-easy
cases, and fix various outdated property references.
    @tornewuff @hasparus
    tornewuff authored and hasparus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    bdc07e7 View commit details
    Browse the repository at this point in the history

  2. Add tests and use const instead

    @tornewuff @hasparus
    tornewuff authored and hasparus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    9bf7062 View commit details
    Browse the repository at this point in the history

  3. Define as actual tests to satisfy jest

    @tornewuff @hasparus
    tornewuff authored and hasparus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    d195a96 View commit details
    Browse the repository at this point in the history

  4. feat(css): add makeTheme constrained identity function 

    Defined presets in a typesafe way.

You can read more on CIFs at:
https://kentcdodds.com/blog/how-to-write-a-constrained-identity-function-in-typescript
    @hasparus
    hasparus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    54af5ba View commit details
    Browse the repository at this point in the history