fix: ignore unused snapshots for skipped test #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanChain
force-pushed
the
fix/skip
branch
3 times, most recently
from
730396d
to
1de9f7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #862 +/- ##
==========================================
+ Coverage 98.30% 98.31% +0.01%
==========================================
Files 20 20
Lines 1530 1545 +15
==========================================
+ Hits 1504 1519 +15
Misses 26 26 |
noahnu
approved these changes
Aug 21, 2024
|
@all-contributors add @AllanChain for bug |
|
I've put up a pull request to add @AllanChain! 🎉 |
noahnu
pushed a commit
that referenced
this pull request
Aug 21, 2024
## [4.6.3](v4.6.2...v4.6.3) (2024-08-21) ### Bug Fixes * ignore unused snapshots for skipped test ([#862](#862)) ([3f6e301](3f6e301))
|
🎉 This PR is included in version 4.6.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tracks the skipped tests and don't mark a snapshot as unused if the corresponding test is skipped.
Related Issues
skiporskipifsyrupy exits with a failure exit code #842Checklist
Additional Comments
No comments.